Remove deprecated RerankerCalculator and update references#4087
Remove deprecated RerankerCalculator and update references#4087michalkulakowski wants to merge 1 commit intoopenvinotoolkit:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated MediaPipe RerankCalculator implementation and its associated proto/config artifacts, keeping the OpenVINO-based RerankCalculatorOV as the supported path.
Changes:
- Deleted the deprecated
RerankCalculatorC++ implementation and itsRerankCalculatorOptionsproto. - Removed Bazel targets and server build references to the deprecated calculator.
- Updated demos/test assets to stop exporting/whitelisting the deprecated calculator (but one test graph/config path still needs follow-up to stay consistent).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Adds missing lockfile entries for Bazel TypeScript deps (appears unrelated to rerank removal). |
src/test/rerank/with_params/invalid_graph_ov.pbtxt |
Removes legacy RerankCalculator node from the invalid OV graph (currently leaves the graph incomplete). |
src/test/rerank/with_params/invalid_graph.pbtxt |
Deletes legacy invalid graph using deprecated calculator. |
src/test/rerank/with_params/graph.pbtxt |
Deletes legacy graph using deprecated calculator. |
src/test/mediapipeflow_test.cpp |
Removes RerankCalculator from the registered-calculators whitelist test. |
src/rerank/rerank_calculator.proto |
Deletes deprecated calculator options proto. |
src/rerank/rerank_calculator.cc |
Deletes deprecated calculator implementation. |
src/rerank/BUILD |
Removes Bazel targets for deprecated calculator/proto. |
src/BUILD |
Removes deprecated calculator from server deps. |
demos/common/export_models/export_model.py |
Removes deprecated rerank export subcommand/templates, leaving rerank_ov. |
| @@ -32,16 +32,5 @@ node { | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
This graph now ends right after the two OpenVINOModelServerSessionCalculator nodes and does not define any node that consumes REQUEST_PAYLOAD and produces RESPONSE_PAYLOAD. src/test/rerank/with_params/invalid_config.json references this file and RerankWithInvalidParamsHttpTest expects the runtime validation error about max_position_embeddings, which will not be triggered with the current graph. Please add a RerankCalculatorOV node with intentionally invalid max_position_embeddings (and update the with_params configs to avoid referencing the deleted legacy graph.pbtxt / invalid_graph.pbtxt).
| } | |
| } | |
| node { | |
| calculator: "RerankCalculatorOV" | |
| input_stream: "REQUEST_PAYLOAD:input" | |
| output_stream: "RESPONSE_PAYLOAD:output" | |
| input_side_packet: "SESSION:tokenizer" | |
| input_side_packet: "SESSION:rerank" | |
| node_options: { | |
| [type.googleapis.com / mediapipe.RerankCalculatorOVOptions]: { | |
| max_position_embeddings: 1 | |
| } | |
| } | |
| } |
No description provided.